Fix AcceptLicensesAsync silently ignoring exit code failures

[Copilot]

AcceptLicensesAsync discarded exitCode/stderr entirely, meaning genuine sdkmanager failures (bad JAVA_HOME, process errors, etc.) were silently treated as success.

Changes

• Exit code handling in AcceptLicensesAsync: Non-zero exits now check output for known benign phrases before deciding to fail
  • Tolerated: output contains "licenses have already been accepted" or "all sdk package licenses accepted"
  • Otherwise: logs error and throws InvalidOperationException with stderr for diagnostics

if (exitCode != 0) {
    var output = (stdout ?? string.Empty) + Environment.NewLine + (stderr ?? string.Empty);
    var outputLower = output.ToLowerInvariant ();

    if (outputLower.Contains ("licenses have already been accepted") ||
        outputLower.Contains ("all sdk package licenses accepted")) {
        logger (TraceLevel.Info, $"License acceptance already completed (exit code {exitCode}).");
        return;
    }

    logger (TraceLevel.Error, $"License acceptance failed (exit code {exitCode}): {stderr}");
    throw new InvalidOperationException ($"Failed to accept SDK licenses: {stderr}");
}

• Tests added for the exit code handling using a fake sdkmanager executable (shell script on Unix, .bat on Windows):
  • Exit code 0 completes successfully
  • Exit code 1 with "All SDK package licenses accepted." is tolerated (benign)
  • Exit code 1 with "Licenses have already been accepted." is tolerated (benign)
  • Exit code 1 with an unrecognized error message throws InvalidOperationException

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[rmarinho]

@copilot how do we test this?

[Copilot]

@copilot how do we test this?

Added 4 tests in commit c35e787 using a fake sdkmanager shell script (.bat on Windows) that emits controlled output and exit codes:

• AcceptLicensesAsync_ExitCodeZero_Succeeds — exit 0 completes normally
• AcceptLicensesAsync_NonZeroWithAllLicensesAcceptedInStdout_Succeeds — exit 1 + "All SDK package licenses accepted." is tolerated
• AcceptLicensesAsync_NonZeroWithLicensesAlreadyAcceptedInStdout_Succeeds — exit 1 + "Licenses have already been accepted." is tolerated
• AcceptLicensesAsync_NonZeroWithUnknownError_Throws — exit 1 + unknown error text throws InvalidOperationException