Skip to content

Conversation

@T-Gro
Copy link
Member

@T-Gro T-Gro commented Dec 18, 2025

No description provided.

@github-actions
Copy link
Contributor

✅ No release notes required

Copy link
Contributor

Copilot AI commented Dec 18, 2025

@T-Gro I've opened a new pull request, #19171, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Support built-in dotnet commands in regression test template

Modified regression-test-jobs.yml to:
- Skip file validation for commands starting with "dotnet"
- Execute dotnet commands directly using Invoke-Expression
- Maintain existing file-based script support
- Handle both Windows and Linux scenarios appropriately

This allows tests like UMX_Slow_Repro to use "dotnet build" directly without requiring a build script file.

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>

* Add security clarification comments for buildScript usage

Added comments to clarify that buildScript comes from pipeline YAML configuration, not external user input, making Invoke-Expression safe in this context.

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>

* Execute provided buildScript on Windows instead of hardcoded build.proj

Changed Windows file-based script execution to use the provided buildScript parameter instead of assuming build.proj exists. Now Windows behavior matches Linux - it executes the actual script specified in the configuration.

Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
@T-Gro T-Gro marked this pull request as ready for review December 22, 2025 18:47
@T-Gro T-Gro requested a review from a team as a code owner December 22, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants