feat: Introduce async handler model with RpcContext#155
Merged
Conversation
Replace the sync `NamekoFunction = fn(&[Value]) -> GirolleResult<Value>`
with an async handler:
Arc<dyn Fn(RpcContext, Payload) -> BoxFuture<GirolleResult<Value>>
+ Send + Sync>
Every RPC delivery now builds an `RpcContext` carrying the routing key
parts, correlation id, reply-to, inbound headers, and two capability
handles (`RpcCaller`, `EventDispatcher`) that follow-up changes will
wire to a shared in-service RPC core and an event publisher. In this
change both capabilities are inert placeholders so handlers can be
typed against them already.
The `#[girolle]` macro now generates an async wrapper, accepts both
`fn` and `async fn` user functions, and detects an optional first
`ctx: RpcContext` argument. Kwargs-to-args dispatch moved into the
generated wrapper so `RpcTask` no longer needs an `args` list.
`RpcTask::new` and the removal of `NamekoFunction` are breaking; the
hand-rolled `examples/src/simple_service.rs` is updated to the new
shape.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the sync
NamekoFunction = fn(&[Value]) -> GirolleResult<Value>with an async handler:Every RPC delivery now builds an
RpcContextcarrying the routing key parts, correlation id, reply-to, inbound headers, and two capability handles (RpcCaller,EventDispatcher) that follow-up changes will wire to a shared in-service RPC core and an event publisher. In this change both capabilities are inert placeholders so handlers can be typed against them already.The
#[girolle]macro now generates an async wrapper, accepts bothfnandasync fnuser functions, and detects an optional firstctx: RpcContextargument. Kwargs-to-args dispatch moved into the generated wrapper soRpcTaskno longer needs anargslist.RpcTask::newand the removal ofNamekoFunctionare breaking; the hand-rolledexamples/src/simple_service.rsis updated to the new shape.