chore: upgrade lapin to 4.6 and adapt to API changes#160
Open
doubleailes wants to merge 1 commit into
Open
Conversation
lapin 4.x bundles its own runtime (via the default tokio feature) and no longer exposes ConnectionProperties::with_executor/with_reactor, so the explicit tokio-executor-trait/tokio-reactor-trait wiring is gone. Heartbeat is now configured through the AMQPUri query field instead of client_properties (which is no longer publicly mutable). Channel API methods (basic_publish, basic_consume, queue_declare, queue_bind, exchange_declare, close) now take ShortString by value, so all string arguments are converted at call sites.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lapin 4.x bundles its own runtime (via the default tokio feature) and
no longer exposes ConnectionProperties::with_executor/with_reactor, so
the explicit tokio-executor-trait/tokio-reactor-trait wiring is gone.
Heartbeat is now configured through the AMQPUri query field instead of
client_properties (which is no longer publicly mutable). Channel API
methods (basic_publish, basic_consume, queue_declare, queue_bind,
exchange_declare, close) now take ShortString by value, so all string
arguments are converted at call sites.