attempt to fix "first snapshot is not read-only" issue#10
Open
kostgr wants to merge 1 commit intodoudou:masterfrom
Open
attempt to fix "first snapshot is not read-only" issue#10kostgr wants to merge 1 commit intodoudou:masterfrom
kostgr wants to merge 1 commit intodoudou:masterfrom
Conversation
Owner
|
Hi. Thanks a lot for the report & fix ! I don't completely understand the issue there still have with your solution. The synchronization lists all snapshots, sorts them and then decides what to synchronize (in There are some style fixes needed in your code, but I can do them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It did a work for me, but the first snapshots, which was synchronized was not the correct one. Some snapshots were skipped. I've modified each()-Method of Snapshot class. It would be better to skip a writable snapshot and take the next one at the time of synchronization. But I couldn't find a correct place for the check quick enough.