Skip to content

Add --against-registry flag for buf breaking#3

Open
sergunya wants to merge 1 commit into
datapoint/codegen/bufbuild__buf-3696-basefrom
datapoint/codegen/bufbuild__buf-3696-solution
Open

Add --against-registry flag for buf breaking#3
sergunya wants to merge 1 commit into
datapoint/codegen/bufbuild__buf-3696-basefrom
datapoint/codegen/bufbuild__buf-3696-solution

Conversation

@sergunya

Copy link
Copy Markdown
Collaborator

This PR adds a --against-registry flag to buf breaking that can be
set in lieu of --against. When --against-registry is set, breaking checks
are run against the latest commit on the default label of the remote module
in the registry.

buf breaking will error if one of --against or --against-registry is
not set:

$ buf breaking
Failure: Must set --against or --against-registry

buf breaking --against-registry will error if not all modules in the input
are named (and thus a remote cannot be resolved):

$ buf breaking --against-registry
Failure: cannot use --against-registry with unnamed module, proto/local

Fixes bufbuild#3654

@sergunya

Copy link
Copy Markdown
Collaborator Author

@dpaia-validator validate

@dpaia-validator

Copy link
Copy Markdown

✅ Datapoint verification passed.

Instance: bufbuild__buf-3696
Duration: 93s
Criteria: compilation: pass, baseline_tests: pass, patch_applied: pass, tests: pass, fail_to_pass: pass, pass_to_pass: pass, fail_to_fail: skipped
Tests: Total: 183, Passed: 183, Failed: 0, Skipped: 0
FAIL_TO_PASS: pass: all fail_to_pass tests fixed

Details: Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants