Add --against-registry flag for buf breaking#3
Open
sergunya wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@dpaia-validator validate |
|
✅ Datapoint verification passed. Instance: Details: Workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a --against-registry flag to buf breaking that can be
set in lieu of --against. When --against-registry is set, breaking checks
are run against the latest commit on the default label of the remote module
in the registry.
buf breaking will error if one of --against or --against-registry is
not set:
$ buf breaking
Failure: Must set --against or --against-registry
buf breaking --against-registry will error if not all modules in the input
are named (and thus a remote cannot be resolved):
$ buf breaking --against-registry
Failure: cannot use --against-registry with unnamed module, proto/local
Fixes bufbuild#3654