Skip to content

feat(@dpc-sdp/ripple-ui-forms): update how active step is determined#1363

Open
lambry wants to merge 8 commits intomainfrom
feature/steps-control-2
Open

feat(@dpc-sdp/ripple-ui-forms): update how active step is determined#1363
lambry wants to merge 8 commits intomainfrom
feature/steps-control-2

Conversation

@lambry
Copy link
Copy Markdown
Contributor

@lambry lambry commented Mar 16, 2026

Issue: https://digital-vic.atlassian.net/browse/SD-1587

What I did

  • Update active step and step number logic
  • Auto run the main step change validation, just so anyone using a custom beforeStepChange function doesn't need to know how, or remeber to run it themselves
  • Add option to exclude steps from review
  • Adding more component tests

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Mar 16, 2026
@lambry lambry marked this pull request as ready for review March 16, 2026 03:31
@lambry lambry requested a review from a team as a code owner March 16, 2026 03:31
@lambry
Copy link
Copy Markdown
Contributor Author

lambry commented Mar 22, 2026

Hey @dylankelly, this (1253ce7) "fixed" the typecript errors around the ripple-core-ui imports in ripple-ui-forms, I feel like there must be a better way to achieve this. What are your thoughts?

@dylankelly dylankelly changed the base branch from feature/steps-control to main April 7, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants