Skip to content

Added nickname mapping and display on pokemon card#85

Open
shinyuX wants to merge 2 commits into
dphuang2:masterfrom
shinyuX:feature/pokemonNicknames
Open

Added nickname mapping and display on pokemon card#85
shinyuX wants to merge 2 commits into
dphuang2:masterfrom
shinyuX:feature/pokemonNicknames

Conversation

@shinyuX

@shinyuX shinyuX commented Aug 22, 2016

Copy link
Copy Markdown

A useless yet essential feature : pokemon nicknames !

screenshot

@Maxoul

Maxoul commented Aug 24, 2016

Copy link
Copy Markdown

Seems neat !

@Limeliz

Limeliz commented Sep 6, 2016

Copy link
Copy Markdown

Good add, which I've been thinking about adding myself. But you need to make the pokemon card higher, because the stamina-bar is clipping throught the bottom of the card for those pokemons who have a nickname.
image

@shinyuX

shinyuX commented Sep 7, 2016

Copy link
Copy Markdown
Author

I had made the card bigger (see my screenshot), I might need to rebase the last added modifications

@YesThatAllen

Copy link
Copy Markdown

I checked this out & restarted my rails server, even created a new sequel lite db and could only see a subset of my data. Some pokemon with and without nicknames showed, but it was an incomplete set regardless. I didn't see any errors in my local log.

How better to test this?

@Limeliz

Limeliz commented Sep 15, 2016

Copy link
Copy Markdown

@shinyuX: I think you forgot to commit the change of the size because it is not showing on github.

@YesThatAllen: add the edit manually. Go to the Change tab of this PR and add the new likes manually to your files. There are only three edit so it will go fast. That is how i did it because I am terrible at git and it works for me.

The nickname data is already store in the DB. This change just shows it on the cards page. If I remember correctlytheh were already showing on another page, Top100 I think.

@shinyuX

shinyuX commented Sep 15, 2016

Copy link
Copy Markdown
Author

That's really odd, I can assure you the card size modification could be seen here. Can someone checkout this and confirm it's ok for him/her/it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants