fix: prevent nullifying nested objects with non-null values in left joins#5986
Open
namdamdoi68-oss wants to merge 2 commits into
Open
fix: prevent nullifying nested objects with non-null values in left joins#5986namdamdoi68-oss wants to merge 2 commits into
namdamdoi68-oss wants to merge 2 commits into
Conversation
namdamdoi68-oss
force-pushed
the
agent/namdamdoi68-oss/issue-1603
branch
from
9e30ddf to
082935a
Compare
Author
|
Hi, I have rebased this PR on top of the latest main branch to resolve the behind state. The changes are up to date and clean. Please let me know if you need any adjustments or if this is ready to be reviewed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1603
Description
This PR fixes a bug where a nested select object under a left join is incorrectly nullified when its first property is
null, even if subsequent properties have non-null values.We update the logic to set the nested object's entry in
nullifyMaptofalseif any non-null column value is encountered for that object.@algora-pbc /claim #1603