Sig nonce fix#829
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes response signature wrapping for proto3 uint64 nonces represented as Java/Kotlin long, ensuring nonces with the high bit set (≥ 2^63) are formatted as unsigned decimal so signature verification can reconstruct the exact wrapped message.
Changes:
- Format the
noncecomponent of the wrapped message using unsigned decimal (Long.toUnsignedString). - Document the unsigned-
uint64nonce expectation and why it matters for signature verification. - Add a regression test asserting nonces with the high bit set are wrapped without a negative sign.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/io/emeraldpay/dshackle/upstream/signature/RsaSigner.kt | Switch nonce formatting to unsigned decimal in wrapMessage and document the uint64↔long behavior. |
| src/test/groovy/io/emeraldpay/dshackle/upstream/signature/RsaSignerSpec.groovy | Add a test case covering wrap behavior for nonces ≥ 2^63. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a10zn8
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.