Skip to content

Sig nonce fix#829

Merged
EugeneDrpc merged 4 commits into
masterfrom
sig-nonce-fix
May 13, 2026
Merged

Sig nonce fix#829
EugeneDrpc merged 4 commits into
masterfrom
sig-nonce-fix

Conversation

@EugeneDrpc
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes response signature wrapping for proto3 uint64 nonces represented as Java/Kotlin long, ensuring nonces with the high bit set (≥ 2^63) are formatted as unsigned decimal so signature verification can reconstruct the exact wrapped message.

Changes:

  • Format the nonce component of the wrapped message using unsigned decimal (Long.toUnsignedString).
  • Document the unsigned-uint64 nonce expectation and why it matters for signature verification.
  • Add a regression test asserting nonces with the high bit set are wrapped without a negative sign.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/main/kotlin/io/emeraldpay/dshackle/upstream/signature/RsaSigner.kt Switch nonce formatting to unsigned decimal in wrapMessage and document the uint64↔long behavior.
src/test/groovy/io/emeraldpay/dshackle/upstream/signature/RsaSignerSpec.groovy Add a test case covering wrap behavior for nonces ≥ 2^63.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@EugeneDrpc EugeneDrpc merged commit b99b74f into master May 13, 2026
5 checks passed
@EugeneDrpc EugeneDrpc deleted the sig-nonce-fix branch May 13, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants