Add padding to iNES header#3
Open
SerhatG wants to merge 1 commit into
Open
Conversation
When adding headers I noticed these roms still would not load using pNes. Comparing them to headered versions showed them missing 6 bytes. When looking at https://www.nesdev.org/wiki/INES it mentioned the header is padded with 6 bytes at the end. Greg Kennedy's version of the script contains these as well. After adding this the roms started working in pNes.
Author
|
Hmm, for most of my roms this seems to work, some don't though (just found out after trying some others). Didn't discern yet what the issue is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding headers I noticed these roms still would not load using pNes.
Comparing them to headered versions showed them missing 6 bytes.
When looking at https://www.nesdev.org/wiki/INES it mentioned the header is padded with 6 bytes at the end.
Greg Kennedy's version of the script contains these as well.
After adding this the roms started working in pNes.