Adding search option to log along with test case#163
Open
idbrii wants to merge 1 commit intodsoprea:masterfrom
Open
Adding search option to log along with test case#163idbrii wants to merge 1 commit intodsoprea:masterfrom
idbrii wants to merge 1 commit intodsoprea:masterfrom
Conversation
1 similar comment
Author
|
Thinking about this a bit more, it might be better to accept a list to allow OR arguments. Or a list of lists to accept OR and AND arguments. But at that point, I don't know how to best communicate that API to the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup of #120 to work with the 1.0 refactor. Mostly that involved rewriting the test case.
I was going to implement this myself, but saw there was an old PR, so I cleaned it up.