Skip to content

Update command syntax for msd to msd_2d#85

Merged
pkawak merged 1 commit into
dssimmons-codes:mainfrom
lazepeda01:patch-1
Apr 30, 2026
Merged

Update command syntax for msd to msd_2d#85
pkawak merged 1 commit into
dssimmons-codes:mainfrom
lazepeda01:patch-1

Conversation

@lazepeda01
Copy link
Copy Markdown
Contributor

@lazepeda01 lazepeda01 commented Apr 29, 2026

Fixed manual command syntax for msd_2d, was previously msd

Fixed manual command for `msd_2d`, was previously `msd`
@pkawak
Copy link
Copy Markdown
Member

pkawak commented Apr 30, 2026

@BaoKhanhMa did we end up fixing the build check?

@BaoKhanhMa
Copy link
Copy Markdown

@BaoKhanhMa did we end up fixing the build check?

  • Yes, we did fix it on the internal version, and you can check it with many recent PRs on internal (which are now closed due to merging). However, he haven't made the internal version into public yet so that's possibly the reason why the build failed here (this is AMDAT public version).

  • Additionally, we fixed it by simply redefining the C/C++ compilers in environmental.yml from getting the version 11.2.0 into the newest one. Here is the attached images for comparison of this change

image image

@pkawak
Copy link
Copy Markdown
Member

pkawak commented Apr 30, 2026

Great job, @BaoKhanhMa. I've now updated public main to reflect that minor change. PR tests now work just fine.

@pkawak pkawak closed this Apr 30, 2026
@pkawak pkawak merged commit c829788 into dssimmons-codes:main Apr 30, 2026
3 of 5 checks passed
@BaoKhanhMa
Copy link
Copy Markdown

Great job, @BaoKhanhMa. I've now updated public main to reflect that minor change. PR tests now work just fine.

Thank you, Dr. Kawak!

@lazepeda01 lazepeda01 deleted the patch-1 branch May 2, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants