Skip to content

Fix apply plan compatibility with old servers #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Jan 28, 2026
Merged

Fix apply plan compatibility with old servers #3507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/dstack/_internal/core/compatibility/runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
from typing import Optional

from dstack._internal.core.models.common import IncludeExcludeDictType, IncludeExcludeSetType
from dstack._internal.core.models.runs import ApplyRunPlanInput, JobSpec, RunSpec
from dstack._internal.core.models.runs import (
DEFAULT_REPLICA_GROUP_NAME,
ApplyRunPlanInput,
JobSpec,
RunSpec,
)
from dstack._internal.server.schemas.runs import GetRunPlanRequest, ListRunsRequest


Expand All @@ -23,7 +28,13 @@ def get_apply_plan_excludes(plan: ApplyRunPlanInput) -> Optional[IncludeExcludeD
current_resource = plan.current_resource
if current_resource is not None:
current_resource_excludes: IncludeExcludeDictType = {}
apply_plan_excludes["current_resource"] = current_resource_excludes
current_resource_excludes["run_spec"] = get_run_spec_excludes(current_resource.run_spec)
current_resource_excludes["jobs"] = {
"__all__": {
"job_spec": get_job_spec_excludes([job.job_spec for job in current_resource.jobs]),
}
}
return {"plan": apply_plan_excludes}


Expand Down Expand Up @@ -70,4 +81,6 @@ def get_job_spec_excludes(job_specs: list[JobSpec]) -> IncludeExcludeDictType:
clients backward-compatibility with older servers.
"""
spec_excludes: IncludeExcludeDictType = {}
if all(s.replica_group == DEFAULT_REPLICA_GROUP_NAME for s in job_specs):
spec_excludes["replica_group"] = True
return spec_excludes