chore: update slophammer-rs to 0.3.0 with reasoned excludes#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI pinned slophammer-rs at 0.1.0, two breaking releases behind.
This change moves the pin to 0.3.0 and adapts the config to its stricter scope rules: excludes that hide production-classified files now need a stated reason, so the
captures/**andsrc/test_fixtures.rsexcludes carry one.With 0.3.0 the repo also gets the new enforcement: CI evidence only counts when it can fail, and the configured scope must cover every production Rust file.
What Changed
The version pin and the exclude entries moved together.
.github/workflows/ci.yml:cargo install slophammer-rs --version 0.1.0→0.3.0.slophammer.yml: thecaptures/**exclude (inexclude,coverage.exclude, anddry.exclude) and thesrc/test_fixtures.rsdry exclude now use the reasoned object form 0.3.0 requires for production-matching patterns. All other keys were already in the current nested shape.Testing
I ran both slophammer commands from
scripts/ci-local.shlocally against the released 0.3.0 binary.slophammer-rs check .— OK: no findings, scope: 35 of 35 production filesslophammer-rs dry . --format json— ok, no findingsci-local.sh(fmt, clippy, coverage, audit, mutants, capture validation) is untouched by this change and runs in this PR's CI.Risks
Low. The config change only adds reasons to existing excludes; no scope or threshold changed.