Drop support for Python 3.9#1423
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
+ Coverage 94.63% 94.71% +0.08%
==========================================
Files 100 100
Lines 10605 10605
==========================================
+ Hits 10036 10045 +9
+ Misses 569 560 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
One thing, the CI builds end up installing NumPy from source for the tests because they use a newer manylinux image that we do. IMO that's fine, if a bit slow. We can update our manylinux image in another PR if we like. |
randomir
left a comment
There was a problem hiding this comment.
LGTM.
Related, you can also drop some deps from tests/requirements.txt that require py<3.9.
| Programming Language :: Cython | ||
| Programming Language :: Python | ||
| Programming Language :: Python :: 3 | ||
| Programming Language :: Python :: 3.9 |
There was a problem hiding this comment.
Not strictly part of dropping 3.9, but would you add 3.14 to the list?
Hmm, that leaves some stuff untested. Let me see if I can raise the version or remove that stuff |
What I meant was, drop the environment marker and update the pinned version. Not actually remove the whole dep. But it's not clear to me what actually gives us.. as we never test on a version older than 3.9 🤔 |
|
Yeah, this all needs a detailed maintenance pass. I pushed some new versions so we get testing. We really should deprecate those functions though, or sweep their range in CI. |
|
Was thinking the same while working on #1420. I can do a pass after that PR. |
AI Generation Disclosure
No AI used.