Skip to content

Drop support for Python 3.9#1423

Merged
arcondello merged 3 commits into
dwavesystems:mainfrom
arcondello:drop-3.9
May 14, 2026
Merged

Drop support for Python 3.9#1423
arcondello merged 3 commits into
dwavesystems:mainfrom
arcondello:drop-3.9

Conversation

@arcondello
Copy link
Copy Markdown
Member

AI Generation Disclosure

No AI used.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.71%. Comparing base (03a19ae) to head (2860340).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
+ Coverage   94.63%   94.71%   +0.08%     
==========================================
  Files         100      100              
  Lines       10605    10605              
==========================================
+ Hits        10036    10045       +9     
+ Misses        569      560       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arcondello arcondello requested a review from randomir May 12, 2026 17:56
@arcondello arcondello marked this pull request as ready for review May 12, 2026 17:56
@arcondello
Copy link
Copy Markdown
Member Author

One thing, the CI builds end up installing NumPy from source for the tests because they use a newer manylinux image that we do. IMO that's fine, if a bit slow. We can update our manylinux image in another PR if we like.

Copy link
Copy Markdown
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Related, you can also drop some deps from tests/requirements.txt that require py<3.9.

Comment thread setup.cfg
Programming Language :: Cython
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.9
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly part of dropping 3.9, but would you add 3.14 to the list?

@arcondello
Copy link
Copy Markdown
Member Author

Related, you can also drop some deps from tests/requirements.txt that require py<3.9.

Hmm, that leaves some stuff untested. Let me see if I can raise the version or remove that stuff

@randomir
Copy link
Copy Markdown
Member

Hmm, that leaves some stuff untested. Let me see if I can raise the version or remove that stuff

What I meant was, drop the environment marker and update the pinned version. Not actually remove the whole dep. But it's not clear to me what

pandas==1.1.4; python_version < '3.9'

actually gives us.. as we never test on a version older than 3.9 🤔

@arcondello
Copy link
Copy Markdown
Member Author

Yeah, this all needs a detailed maintenance pass. I pushed some new versions so we get testing. We really should deprecate those functions though, or sweep their range in CI.

@randomir
Copy link
Copy Markdown
Member

Was thinking the same while working on #1420. I can do a pass after that PR.

@arcondello arcondello merged commit aca7cc3 into dwavesystems:main May 14, 2026
36 checks passed
@arcondello arcondello deleted the drop-3.9 branch May 14, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants