Add preliminary QCDL support#745
Conversation
2e85457 to
8b61a8b
Compare
8b61a8b to
d831938
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 44 44
Lines 5300 5313 +13
=======================================
+ Hits 4766 4778 +12
- Misses 534 535 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| _handled_encoding_formats = {"binary-ref"} | ||
|
|
||
| def _encode_problem_for_upload(self, qcdl, **kwargs): | ||
| return orjson.dumps(qcdl) |
There was a problem hiding this comment.
I wonder if a try/except here might help some users debug in the future.
OTOH we don't have evidence that this is a common failure path, so until we do probably better to leave it alone. Ok, I talked myself out of it, but leaving the comment for posterity 😄
There was a problem hiding this comment.
Once we integrate QCDL generation into Ocean, we'll be able to do better checks here. Or even defer serialization completely. Just like we do with NL (and require dwave-optimization) or BQM/CQM/DQM (and require dimod).
Example:
Alternatively, to upload the circuit first, replace the
sample_qcdlline with:AI Generation Disclosure
No AI used.