Raise clear error for non-BQM embedding inputs#607
Open
matti-sarjala wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463.
This updates embedding composites to reject non-BQM inputs with a clear TypeError before accessing BQM-specific attributes such as
.linearand.quadratic.The motivating case is passing a CQM to
EmbeddingComposite(DWaveSampler()).sample(...). Previously this failed with an internal AttributeError, which made it look like the CQM was missing a BQM attribute. The new error makes the model contract explicit: embedding composites accept BQMs, while CQMs should use an appropriate CQM sampler such asLeapHybridCQMSampler.A regression test is included for CQM input.