fix: bug fix for adding nested entity relations#119
Open
marmionl wants to merge 1 commit intodweber019:mainfrom
Open
fix: bug fix for adding nested entity relations#119marmionl wants to merge 1 commit intodweber019:mainfrom
marmionl wants to merge 1 commit intodweber019:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasOwnPropertywas previously used in the processor to find the attribute used for a relation, defined in theapp-config.yamlfile. This function does not have any understanding for dot notation paths so it was failing to add relations that made use of this (i.e. nested relations). The check would therefore returnfalseand exit early before any relation processing occured, including a previous feature implementation for nested relations, a0ff803 .This change simply switches out this function for the
getfunction from lodash (also used in the previous implementaiton attempt). Screenshots from before and after provided below, note that theproductOwnerrelation did not generate before this fix, but now does.Before:
After:
N.B. the relationship graph does not show any custom relationships, but the relationship table does. I have fixed this locally my end but the solution was a bit of a hack so I don't think it's worth contributing to the plugin for now. The nested relationships are being generated however as you can see in the inspected entities