added handling of 3d numpy arrays and lists of uneven numpy arrays #62
Open
mitchellostrow wants to merge 1 commit intodynamicslab:masterfrom
Open
added handling of 3d numpy arrays and lists of uneven numpy arrays #62mitchellostrow wants to merge 1 commit intodynamicslab:masterfrom
mitchellostrow wants to merge 1 commit intodynamicslab:masterfrom
Conversation
…ials,n_samples, n_features) a well as lists of trajectories, potentially of different sample sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datasets I work with are typically of two possible shapes:
We would like our DMD fitting procedure to be able to flexibly handle these arrays. The main functionality I've therefore added is the following:
I've added testing for each class as well to handle this separate cases. All tests pass and code has been properly formatted.