Merged
Conversation
| - You must run `pnpm cicheck` before committing to verify quality. | ||
| - You must not use here documents because it causes a sandbox error. | ||
| - You must not use `--no-verify` option because it skips pre-commit checks and causes serious security issues. | ||
| - When creating a PR, you should include a link in the PR description that associates the PR with its issue. |
dyoshikawa
deleted the
codex/add-instruction-to-link-issues-in-pr-description
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.rulesync/rules/overview.mdのWhen doinggit commit`` セクションに、PR作成時はPR descriptionに関連Issueへのリンクを含める旨の一行を追加しました。Testing
pnpm cicheck（内部でpnpm run testを含む）で、最初にcspellが一時生成物の影響で失敗したものの一時生成物を削除して再実行した結果、全てのチェックを通過し、テストは4845件すべて成功しました。Codex Task