Skip to content

Include E2E spec glob in testing-guidelines rule#1464

Merged
dyoshikawa merged 1 commit intomainfrom
codex/add-e2e-test-glob-path-to-testing-guidelines
Apr 12, 2026
Merged

Include E2E spec glob in testing-guidelines rule#1464
dyoshikawa merged 1 commit intomainfrom
codex/add-e2e-test-glob-path-to-testing-guidelines

Conversation

@dyoshikawa
Copy link
Copy Markdown
Owner

Motivation

  • Ensure the testing guidelines also apply to end-to-end spec files under src/e2e/**/*.spec.ts so E2E tests follow the same conventions as unit tests.

Description

  • Update frontmatter in .rulesync/rules/testing-guidelines.md to add src/e2e/**/*.spec.ts to the globs list alongside the existing **/*.test.ts pattern.

Testing

  • Ran pnpm cicheck, which runs format checks, linters, type checks, vitest tests, cspell, and secretlint, and all checks passed; vitest reported 180 test files and 4845 tests passed.

Codex Task

Copilot AI review requested due to automatic review settings April 12, 2026 14:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Rulesync testing guidelines rule so the same conventions apply to end-to-end (E2E) spec files under src/e2e/**/*.spec.ts, aligning E2E tests with existing unit-test conventions.

Changes:

  • Expanded the .rulesync/rules/testing-guidelines.md frontmatter globs to include src/e2e/**/*.spec.ts in addition to **/*.test.ts.

@dyoshikawa dyoshikawa merged commit 8442775 into main Apr 12, 2026
9 checks passed
@dyoshikawa dyoshikawa deleted the codex/add-e2e-test-glob-path-to-testing-guidelines branch April 12, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants