Include E2E spec glob in testing-guidelines rule#1464
Merged
dyoshikawa merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rulesync testing guidelines rule so the same conventions apply to end-to-end (E2E) spec files under src/e2e/**/*.spec.ts, aligning E2E tests with existing unit-test conventions.
Changes:
- Expanded the
.rulesync/rules/testing-guidelines.mdfrontmatterglobsto includesrc/e2e/**/*.spec.tsin addition to**/*.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/e2e/**/*.spec.tsso E2E tests follow the same conventions as unit tests.Description
.rulesync/rules/testing-guidelines.mdto addsrc/e2e/**/*.spec.tsto theglobslist alongside the existing**/*.test.tspattern.Testing
pnpm cicheck, which runs format checks, linters, type checks,vitesttests,cspell, andsecretlint, and all checks passed;vitestreported180test files and4845tests passed.Codex Task