ACL tweaks for #666 #670
Closed
amillionbouncyballs wants to merge 1 commit into
Closed
Conversation
…r JSONStorage writes Small follow-ups stacked on top of e-dream-ai#666 (commit 47f25e9). Intended to be merged onto fix-resume-busyloop-streaming-fallback; the PR is based on that branch so the diff is just these tweaks. 1. preflightNextDream now streams as a last resort when canStream=false and the cache is totally empty (the busyloop fix). The call-site comments and header doc still said "don't allow streaming", which is no longer accurate -- updated to reflect the fallback. 2. JSONStorage::GetOrSetValue: on the write path, returning false on exception left the corrupt value in place, while the wrapper Set methods return true unconditionally -- so callers saw a "successful" write that never happened and the bad value was persisted into Finalise. Repair the slot in place via _emplace on the set path so it doesn't recur.
amillionbouncyballs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-ups stacked on top of #666 (commit 47f25e9). Intended to be merged onto fix-resume-busyloop-streaming-fallback; the PR is based on that branch so the diff is just these tweaks.
preflightNextDream now streams as a last resort when canStream=false and the cache is totally empty (the busyloop fix). The call-site comments and header doc still said "don't allow streaming", which is no longer accurate -- updated to reflect the fallback.
JSONStorage::GetOrSetValue: on the write path, returning false on exception left the corrupt value in place, while the wrapper Set methods return true unconditionally -- so callers saw a "successful" write that never happened and the bad value was persisted into Finalise. Repair the slot in place via _emplace on the set path so it doesn't recur.