fix(lang): Replace generic 'his/he' with singular 'they'#5646
Merged
Conversation
Deltik
requested changes
May 19, 2026
Two user-facing English LAN values used masculine generic pronouns for
an unspecified user. Switches them to singular 'they' in PRFLAN_38 and
PRFLAN_91 of e107_languages/English/admin/lan_prefs.php.
PRFLAN_38 also drops a subject-verb agreement nit ("a user post" ->
"a user posts") that falls out of the same edit.
Reported by @BillyBoy0823 in #5642.
e107help
Bot
force-pushed
the
e107help/5642
branch
from
662818f to
19e1f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @BillyBoy0823 in #5642. Two generic-singular
his/hereferences in user-facing English LAN strings.Changes
e107_languages/English/admin/lan_prefs.phpPRFLAN_38(line 41): "if a user post too fast, he will be redirected" → "if a user posts too fast, they will be redirected" (singular-they plus a subject-verb agreement nit)e107_languages/English/admin/lan_prefs.phpPRFLAN_91(line 84): "his IP will be automatically banned" → "their IP will be automatically banned"Why the scope shrank
Initial commit also touched
e107_docs/help/English/Administratorsande107_docs/help/English/Forums. PR #5596 (feat/admin-docs-rich-renderer) rewrites all 21 English help files into a new line-based format, so the help-doc edits were either (a) on a line that is replaced wholesale by the rewrite (Administrators), or (b) already applied in #5596's tree on the same line (Forums). Both dropped to avoid conflicting with #5596; thanks to @Deltik for the catch.Backwards compatibility
LAN constants are keyed by name, not by value.
PRFLAN_38andPRFLAN_91keep their identifiers; only the English value changes. Translation packs in e107translations override the English string as they always have, so this is a no-op for any non-English install.Test plan