Skip to content

Restyle English_front.php#5755

Open
tgtje wants to merge 1 commit into
e107inc:masterfrom
tgtje:tgtje-patch-1
Open

Restyle English_front.php#5755
tgtje wants to merge 1 commit into
e107inc:masterfrom
tgtje:tgtje-patch-1

Conversation

@tgtje

@tgtje tgtje commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

language conversion failed ?

only LAn 'GSLAN_Name' => "Sitemap" is correct in place

Why

during translation conversion? LAN lines who were commented out became activated

What Changed

open file where only first LAN ( name=sitemap) is used in Front php
rest of file commented out again

How It Was Tested

running checks on LAN"s in use but they do not exist anymore or now present in langfiles gsitemap/languages/English_admin.php and gsitemap/admin_config.php

Backwards Compatibility

No BC impact.

Checklist

  • One issue per PR: the diff is scoped to this change only
  • Commit messages explain why, not just what
  • New or changed behavior has test coverage
  • No unrelated reformatting, renames, or import reordering

language conversion failed 
only 'GSLAN_Name' => "Sitemap"  is correct
@rica-carv

rica-carv commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@tgtje Have you tried my constant to array lan convert script ???
It skips commented constants / text in old lan files....

@tgtje

tgtje commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@rica-carv i know, and tested (ok) but it is in core system (Cameron's conversion failed here ?)

@rica-carv

rica-carv commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

but it is in core system (Cameron's conversion failed here ?)

@tgtje Ah, got it, sorry, my mistake.... i was thinking you were converting it... sorry...

@tgtje

tgtje commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Helas a few hours later... more coming ( in time > poll + rrs_menu ) 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants