Skip to content

fix for conversion error in core + 1 LAN change#5776

Open
tgtje wants to merge 3 commits into
e107inc:masterfrom
tgtje:master
Open

fix for conversion error in core + 1 LAN change#5776
tgtje wants to merge 3 commits into
e107inc:masterfrom
tgtje:master

Conversation

@tgtje

@tgtje tgtje commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Why

Fix conversion error whre commented LAN's are activated

What Changed

restyled and repaired ( 1 lan in poll class changed into word) as no longer exists in that matter (forum old) the (LAN_4) itself is reused for other (eg in lan top.php)

How It Was Tested

on local machine heavy testing

Backwards Compatibility

No BC impact. (only late v 0.6 versions might be affected)

Checklist

  • One issue per PR: the diff is scoped to this change only
  • Commit messages explain why, not just what
  • New or changed behavior has test coverage (or explain why not)
  • No unrelated reformatting, renames, or import reordering

tgtje added 3 commits June 15, 2026 18:41
forgotten lan after forum rebuild
@tgtje

tgtje commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

For your convenience (untouched) : the MAIN English language file >English.php is not equal in styling (uses "..." ).
Do not know if intended or typo.

@Alex-e107nl

Copy link
Copy Markdown
Contributor

Hi @tgtje do you mean this:

// const CORE_LC = "en";
// const CORE_LC2 = "gb";

return [
	"CORE_LC" => "en",
	"CORE_LC2" => "gb",
const CORE_LC = "en";
const CORE_LC2 = "gb";	

Gives a php error double declaration...

@tgtje

tgtje commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

No i think, (guessing what you mean) @Alex-e107nl styling as explained for lan files should have
'LAN_TEST' = > "descript", << single ' front '
Now for main English php they are
"LAN_TEST" = > "descript", < double " front "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants