Skip to content

fix(settings): lowercase info rows with inline copy-on-hover#349

Merged
drankou merged 2 commits into
mainfrom
fix/settings-lowercase-copy-on-hover
May 29, 2026
Merged

fix(settings): lowercase info rows with inline copy-on-hover#349
drankou merged 2 commits into
mainfrom
fix/settings-lowercase-copy-on-hover

Conversation

@drankou
Copy link
Copy Markdown
Contributor

@drankou drankou commented May 28, 2026

  • Drop the forced uppercase on team info labels and values, and remove the onCopy override that was copying underlying text content
  • Reveal the existing CopyButton inline on row hover
Before After
CleanShot 2026-05-28 at 16 01 58@2x CleanShot 2026-05-28 at 16 02 15@2x

@drankou drankou requested a review from ben-fornefeld as a code owner May 28, 2026 13:44
@cla-bot cla-bot Bot added the cla-signed label May 28, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment May 29, 2026 8:11am
web-juliett Ready Ready Preview, Comment May 29, 2026 8:11am

Request Review

Drop the forced text-transform: uppercase on team info labels and
values, and remove the onCopy override that existed only to mask it.

Reveal the existing CopyButton inline on row hover / keyboard focus
using the project's group/row + group-has-[:focus-visible] pattern.

Co-Authored-By: Craft Agent <agents-noreply@craft.do>
@drankou drankou merged commit 069a4bf into main May 29, 2026
14 checks passed
@drankou drankou deleted the fix/settings-lowercase-copy-on-hover branch May 29, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants