feat(storage): rationalize read path OTEL#2831
Open
levb wants to merge 5 commits into
Open
Conversation
❌ 6 Tests Failed:
View the full list of 6 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Adds an orchestrator.read.* metric family with consistent attributes
(file_type/source/codec/outcome) covering each stage of a read, plus
per-layer chunker and build-file timers, so dashboards can attribute
latency end-to-end from sandbox-visible read to backend fetch.
Does not remove any of the prior metrics, this will be done separately
after the dashboards are updated.
Metrics:
- orchestrator.file.read_at build.File.ReadAt — per-fault
unit, aggregates all underlying
mappings into one record
- orchestrator.chunk.slice Chunker.Slice — per per-mapping
unit, source=mmap on cache hit
else the backend that served
- orchestrator.read.open OpenRangeReader (open / TTFB)
- orchestrator.read.read source-read wall, compressed bytes
- orchestrator.read.decompress decompress CPU + uncompressed bytes
- orchestrator.read.fetch total fetch wall + bytes delivered
- orchestrator.read.writeback NFS cache writeback wall + bytes
- orchestrator.read.pipeline.efficiency fetch / (open+read+decompress)
- orchestrator.read.cache NFS hit/miss/writeback events
- orchestrator.read.inflight concurrent fetches gauge
Spans:
- chunk.fetch runFetch goroutine span
levb
force-pushed
the
lev-gcs-read-ttfb-metric
branch
from
f1d1973 to
f7a0b35
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8b2cff410
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2035d4a86c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds to #2570 which should be merged first.
Adds an orchestrator.read.* metric family with consistent attributes
(file_type/source/codec/outcome) covering each stage of a read, plus
per-layer chunker and build-file timers, so dashboards can attribute
latency end-to-end from sandbox-visible read to backend fetch.
Does not remove any of the prior metrics, this will be done separately
after the dashboards are updated.
Metrics:
orchestrator.file.read_atbuild.File.ReadAt - per-fault unit, aggregates all underlying mappings into one recordorchestrator.chunk.sliceChunker.Slice - per per-mapping unit, source=mmap on cache hit else the backend that servedorchestrator.read.open- OpenRangeReader (open / TTFB)orchestrator.read.read- source-read wall time, raw bytesorchestrator.read.decompress- decompress wall time + uncompressed bytesorchestrator.read.fetch- total fetch wall time + uncompressed bytes deliveredorchestrator.read.writeback- NFS cache writeback wall + bytesorchestrator.read.pipeline.efficiency- fetch / (open+read+decompress)orchestrator.read.cache- NFS hit/miss/writeback eventsorchestrator.read.inflight- concurrent fetches gaugeSpans:
chunk.fetch- runFetch goroutine span