refactor(api): extract inlined request body schemas#2837
Open
mishushakov wants to merge 1 commit into
Open
Conversation
- Extract sandbox timeout/refresh/snapshot request bodies into named components (SandboxTimeoutRequest, SandboxRefreshRequest, SandboxSnapshotRequest) so consumers can reference them by name instead of via inlined path-derived types. - Drop pointless `items.allOf: [$ref]` wrappers on the list endpoints GET /teams, /sandboxes, /v2/sandboxes, /templates, /nodes — these caused generators to emit anonymous wrapper types for no benefit. - Regenerate API and integration test clients; switch two handlers to the new named types (old anonymous *JSONBody symbols no longer exist).
mishushakov
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 45c13a1. Bugbot is set up for automated code reviews on this repo. Configure here. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 5 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /sandboxes/{id}/timeout,/refreshes,/snapshots) into named component schemas:SandboxTimeoutRequest,SandboxRefreshRequest,SandboxSnapshotRequest. This follows the same pattern as refactor(api): extract SandboxNetworkUpdateConfig schema #2748 (SandboxNetworkUpdateConfig) and gives consumers a stable name to reference instead of a path-derived anonymous type.items.allOf: [$ref]wrappers on five list endpoints (GET /teams,/sandboxes,/v2/sandboxes,/templates,/nodes); the wrapper caused generators to emit anonymous element types for no semantic gain.*JSONRequestBodysymbols are now type aliases to the named schemas, so existing call sites compile unchanged. Two handlers (sandbox_refresh.go,sandbox_timeout.go) used the removed*JSONBodyinner type and were switched to the new named types.Test plan
go build ./...inpackages/apigo vet ./internal/...intests/integrationmake fmt/make lint— could not run locally; local golangci-lint was built against Go 1.25 but the repo targets 1.26.3. CI will run both.🤖 Generated with Claude Code