Skip to content

support configuring nomad/consul/vault/ebi versions#2868

Draft
djeebus wants to merge 8 commits into
mainfrom
support-more-versions
Draft

support configuring nomad/consul/vault/ebi versions#2868
djeebus wants to merge 8 commits into
mainfrom
support-more-versions

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented May 30, 2026

No description provided.

@cla-bot cla-bot Bot added the cla-signed label May 30, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented May 30, 2026

PR Summary

Low Risk
Defaults are unchanged; risk is mainly picking wrong versions or base images via new optional build variables.

Overview
This PR makes Nomad cluster disk image builds easier to parameterize and more reliable on repeat runs. Consul and Nomad install scripts now use unzip -o so extracted binaries overwrite cleanly when a build is re-run. AWS and GCP Packer Makefiles pass optional environment-driven overrides for Consul and Nomad versions, networking, and base images instead of relying only on fixed CLI flags. AWS exposes a configurable source AMI filter (same default as before); GCP exposes a configurable source image (same default as before).

Reviewed by Cursor Bugbot for commit ecc874b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request parameterizes the source AMI filter name and Packer build variables, and updates the Consul and Nomad installation scripts to use the unzip -n flag. However, using -n prevents overwriting existing binaries in /tmp, which could silently result in outdated or incorrect versions being installed; it is recommended to use the -o flag instead to force overwriting.

Comment thread iac/nomad-cluster-disk-image/setup/install-consul.sh Outdated
Comment thread iac/nomad-cluster-disk-image/setup/install-nomad.sh Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2695 4 2691 7
View the full list of 4 ❄️ flaky test(s)
github.com/e2b-dev/infra/tests/integration/internal/tests/api/sandboxes::TestSandboxListPaginationRunningLargerLimit

Flake rate in main: 42.85% (Passed 739 times, Failed 554 times)

Stack Traces | 96.3s run time
=== RUN   TestSandboxListPaginationRunningLargerLimit
    sandbox_list_test.go:327: Created sandbox 1/12: i34caxsz8jiotnd35sh64
    sandbox_list_test.go:327: Created sandbox 2/12: i7sx5j3ff8bq1vfo61vg1
    sandbox_list_test.go:327: Created sandbox 3/12: izyplj4w64pr0b41bqgbc
    sandbox_list_test.go:327: Created sandbox 4/12: iupufwr1cl4fx4hqi8s05
    sandbox_list_test.go:327: Created sandbox 5/12: iifd491uswo6auu1ynihy
    sandbox_list_test.go:327: Created sandbox 6/12: ibrutz9qz3uu8fdyrmz5w
    sandbox_list_test.go:327: Created sandbox 7/12: i8p8hdz63xu7pi6ev95nv
    sandbox_list_test.go:327: Created sandbox 8/12: ilnex5zoeabrw32ojcqib
    sandbox_list_test.go:327: Created sandbox 9/12: i28ar87un67nupi845ygl
    sandbox_list_test.go:327: Created sandbox 10/12: i0o8ndwa94tdwo5rdw7ul
    sandbox_list_test.go:327: Created sandbox 11/12: i6mm1g2c7zsgfefm5vstt
    sandbox_list_test.go:327: Created sandbox 12/12: ig76jsapqniwm3alnfbco
    sandbox_list_test.go:330: 
        	Error Trace:	.../api/sandboxes/sandbox_list_test.go:340
        	            				.../hostedtoolcache/go/1.26.3.../src/runtime/asm_amd64.s:1771
        	Error:      	"[]" should have 12 item(s), but has 0
    sandbox_list_test.go:330: 
        	Error Trace:	.../api/sandboxes/sandbox_list_test.go:330
        	Error:      	Condition never satisfied
        	Test:       	TestSandboxListPaginationRunningLargerLimit
--- FAIL: TestSandboxListPaginationRunningLargerLimit (96.29s)
github.com/e2b-dev/infra/tests/integration/internal/tests/orchestrator::TestSandboxMemoryIntegrity

Flake rate in main: 57.74% (Passed 732 times, Failed 1000 times)

Stack Traces | 55.9s run time
=== RUN   TestSandboxMemoryIntegrity
=== PAUSE TestSandboxMemoryIntegrity
=== CONT  TestSandboxMemoryIntegrity
    sandbox_memory_integrity_test.go:27: Build completed successfully
--- FAIL: TestSandboxMemoryIntegrity (55.89s)
github.com/e2b-dev/infra/tests/integration/internal/tests/orchestrator::TestSandboxMemoryIntegrity/tmpfs_hash

Flake rate in main: 57.85% (Passed 722 times, Failed 991 times)

Stack Traces | 211s run time
=== RUN   TestSandboxMemoryIntegrity/tmpfs_hash
=== PAUSE TestSandboxMemoryIntegrity/tmpfs_hash
=== CONT  TestSandboxMemoryIntegrity/tmpfs_hash
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{start:{pid:1257}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stdout:"Total memory: 985 MB\nUsed memory before tmpfs mount: 193 MB\nFree memory before tmpfs mount: 791 MB\nMemory to use in integrity test (60% of free, min 64MB): 474 MB\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"474+0 records in\n474+0 records out\n497025024 bytes (497 MB, 474 MiB) copied, 7.21492 s, 68.9 MB/s\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"\tCommand being timed: \"dd if=/dev/urandom of=/mnt/testfile bs=1M count=474\"\n\tUser time (seconds): 0.00\n\tSystem time (seconds): 7.06\n\tPercent of CPU this job got: 97%\n\tElapsed (wall clock) time (h:mm:ss or m:ss): 0:07.23\n\tAverage shared text size (kbytes): 0\n\tAverage unshared data size (kbytes): 0\n\tAverage stack size (kbytes): 0\n\tAverage total size (kbytes): 0\n\tMaximum resident set size (kbytes): 2688\n\tAverage resident set size (kbytes): 0\n\tMajor (requiring I/O) page faults: 3\n\tMinor (reclaiming a frame) page faults: 344\n\tVoluntary context switches: 4\n\tInvoluntary context switches: 93\n\tSwaps: 0\n\tFile system inputs: 176\n\tFile system outputs: 0\n\tSocket messages sent: 0\n\tSocket messages received: 0\n\tSignals delivered: 0\n\tPage size (bytes): 4096\n\tExit status: 0\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stdout:"Used memory after tmpfs mount and file fill: 671 MB\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{end:{exited:true  status:"exit status 0"}}
    sandbox_memory_integrity_test.go:70: Command [bash] completed successfully in sandbox is8ozl5qzvrqtpq70orca
Executing command bash in sandbox is8ozl5qzvrqtpq70orca (user: root)
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{start:{pid:1273}}
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{data:{stdout:"0d207b54b031846bc2e5b6c26bda1900d62699eab18f7ba86ff948271ad4b5d9\n"}}
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{end:{exited:true  status:"exit status 0"}}
    sandbox_memory_integrity_test.go:80: Command [bash] completed successfully in sandbox is8ozl5qzvrqtpq70orca
Executing command bash in sandbox ivqatyt9ggyj0j68n0g6z (user: root)
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{start:{pid:1276}}
Executing command bash in sandbox ivqatyt9ggyj0j68n0g6z (user: root)
    sandbox_memory_integrity_test.go:110: 
        	Error Trace:	.../tests/orchestrator/sandbox_memory_integrity_test.go:81
        	            				.../hostedtoolcache/go/1.26.3.../src/runtime/asm_amd64.s:1771
        	Error:      	Received unexpected error:
        	            	failed to execute command bash in sandbox is8ozl5qzvrqtpq70orca: unavailable: HTTP status 502 Bad Gateway
    sandbox_memory_integrity_test.go:110: 
        	Error Trace:	.../tests/orchestrator/sandbox_memory_integrity_test.go:78
        	            				.../tests/orchestrator/sandbox_memory_integrity_test.go:110
        	Error:      	Condition never satisfied
        	Test:       	TestSandboxMemoryIntegrity/tmpfs_hash
--- FAIL: TestSandboxMemoryIntegrity/tmpfs_hash (210.67s)
github.com/e2b-dev/infra/tests/integration/internal/tests/proxies::TestSandboxAutoResumeViaProxy

Flake rate in main: 43.63% (Passed 726 times, Failed 562 times)

Stack Traces | 12.3s run time
=== RUN   TestSandboxAutoResumeViaProxy
=== PAUSE TestSandboxAutoResumeViaProxy
=== CONT  TestSandboxAutoResumeViaProxy
    auto_resume_test.go:116: 
        	Error Trace:	.../tests/proxies/auto_resume_test.go:116
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:3002": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
        	Test:       	TestSandboxAutoResumeViaProxy
--- FAIL: TestSandboxAutoResumeViaProxy (12.30s)
Executing command ls in sandbox iutzuzp38sf6mx2kmfbi8

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Comment thread iac/provider-aws/nomad-cluster-disk-image/Makefile Outdated
Comment thread iac/nomad-cluster-disk-image/setup/install-consul.sh Outdated
Comment thread iac/provider-aws/nomad-cluster-disk-image/Makefile Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d227a32. Configure here.

Comment thread iac/provider-gcp/nomad-cluster-disk-image/Makefile Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant