Skip to content

fix: EgovMyBatisBatchItemWriter의 사용되지 않는 reflection 루프 제거 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
z3rotig4r wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: EgovMyBatisBatchItemWriter의 사용되지 않는 reflection 루프 제거 #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions ...re/src/main/java/org/egovframe/rte/bat/core/item/database/EgovMyBatisBatchItemWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,6 @@
import org.egovframe.rte.bat.support.EgovResourceVariable;
import org.egovframe.rte.bat.support.EgovStepVariableListener;
import org.mybatis.spring.batch.MyBatisBatchItemWriter;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.batch.item.Chunk;
import org.springframework.util.ReflectionUtils;

import java.beans.BeanInfo;
import java.beans.IntrospectionException;
import java.beans.Introspector;
import java.beans.PropertyDescriptor;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* EgovMyBatisBatchItemWriter 클래스
Expand All @@ -54,8 +39,6 @@
*/
public class EgovMyBatisBatchItemWriter<T> extends MyBatisBatchItemWriter<T> {

private static final Logger LOGGER = LoggerFactory.getLogger(EgovMyBatisBatchItemWriter.class);

/**
* egovframework EgovResourceVariable
*/
Expand Down Expand Up @@ -95,37 +78,4 @@ public void setStepVariable(EgovStepVariableListener stepVariable) {
this.stepVariable = stepVariable;
}

@Override
@SuppressWarnings("unchecked")
public void write(Chunk<? extends T> chunk) {
List<Object> list = new ArrayList<>();
Map<String, Object> map;

try {
for (T item : chunk.getItems()) {
map = new HashMap<>();
BeanInfo beanInfo = Introspector.getBeanInfo(item.getClass());

if (resourceVariable != null)
map.putAll(resourceVariable.getVariableMap());
if (jobVariable != null)
map.putAll(jobVariable.getVariableMap());
if (stepVariable != null)
map.putAll(stepVariable.getVariableMap());

for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
Method reader = pd.getReadMethod();
if (reader != null)
map.put(pd.getName(), reader.invoke(item));
}

list.add(map);
}
} catch (IntrospectionException | IllegalAccessException | InvocationTargetException e) {
ReflectionUtils.handleReflectionException(e);
}

super.write((Chunk<? extends T>) chunk);
}

}