refactor: EgovUUIdGnrServiceImpl dead assignment 제거#247
Open
z3rotig4r wants to merge 1 commit into
Open
Conversation
동작 변화 없이 무의미한 dead assignment 두 곳을 정리했습니다. - setAddress: `Random random = new Random()`가 바로 다음 줄 `random = SecureRandom.getInstanceStrong()`로 덮어써집니다. 변수를 SecureRandom으로 바로 초기화하도록 했습니다. - generateIdFromTimestamp: `time = currentTimeMillis`가 바로 다음 줄 `time = currentTimeMillis << 32`로 덮어써집니다. 제거했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
내용
EgovUUIdGnrServiceImpl에서 바로 다음 줄에 덮어써지는 무의미한 dead assignment 두 곳을 정리했습니다. 동작 변화는 없습니다.setAddress
new Random()인스턴스가 생성 직후 버려집니다. 변수를SecureRandom.getInstanceStrong()으로 바로 초기화하도록 했습니다.generateIdFromTimestamp
첫 할당이 바로 다음 줄에서 덮어써지므로 제거했습니다.
검증
동작 변경이 없는 정리이므로 기존 테스트로 회귀를 확인했습니다.