IG RINDA YUDA WARDANA by Yudawardana94 · Pull Request #28 · eager-fox-2019/mini-wp

Yudawardana94 · 2019-06-24T01:33:55Z

ENV yang saya gunakan :
PORT=3000
JWT_SECRET=helloworld
CLIENT_ID=132166001773-nljl5umc0vmdlvodji12sfl1eqk051q7.apps.googleusercontent.com
GCLOUD_PROJECT=yudawardana-1560407905203
CLOUD_BUCKET=yuda-wardana
KEYFILE_PATH=keyfile.json

WikaSilo · 2019-06-24T04:21:23Z

@@ -0,0 +1,12 @@
+{


Jangan push keyfie.json!
dihapus yaa

WikaSilo · 2019-06-24T04:21:39Z

+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "dev": "nodemon app.js",
+    "start": "nodemon app.js"


biasanya kalo start, tidak menggunakan nodemon

WikaSilo · 2019-06-24T04:22:51Z

@@ -0,0 +1,6 @@
+PORT=3000


valuenya tidak perlu diisi, kasih kosong saja

WikaSilo · 2019-06-24T04:23:23Z

@@ -0,0 +1,32 @@
+if (!process.env.NODE_ENV || process.env.NODE_ENV === "development") {


padahal di script kamu tidak menggunakan NODE_ENV. jika masih bingung bisa ditanya yaa

WikaSilo · 2019-06-24T04:24:06Z

+const port = process.env.PORT;
+
+mongoose.connect(
+  "mongodb://localhost:27017/Mini-WP",


tips: untuk url bisa dibuat variable tersendiri

WikaSilo · 2019-06-24T04:25:24Z

@@ -0,0 +1,10 @@
+let errHandler = (err, req, res, next) => {
+  let code = err.status;
+  let message = err.message;


terkait message, ada beberapa yang biasanya handle lebih umum seperti Internal Server Error. Dan ada beberapa yang bentuknya array, jadi lebih spesifik lagi untuk handlenya ya

WikaSilo · 2019-06-24T04:26:04Z

+route.use("/users", userR);
+route.use("/articles", articleR);
+
+route.get("/*", (req, res) => {


tips: kamu bisa menggunakan ini untuk check 404 page not found, jadi disesuaikan penggunaannya

WikaSilo · 2019-06-24T04:26:35Z

@@ -0,0 +1,13 @@
+const route = require("express").Router();
+const userR = require("../routes/userRoutes");


kenapa keluar folder terus masuk ke folder lagi yang sama untuk aksesnya?

WikaSilo · 2019-06-24T04:26:51Z

+route.post("/login/google", userController.loginGoogle);
+route.post("/login", userController.login);
+
+route.post("/*", (req, res) => {


ini untuk apa ya?

WikaSilo · 2019-06-24T04:27:26Z

@@ -0,0 +1,24 @@
+const route = require("express").Router();
+const articleC = require("../controller/articleController");


tips: jika controller, sebaiknya tidak perlu di singkat jadi articleC, route juga

WikaSilo · 2019-06-24T04:27:42Z

+  images.sendUploadToGCS,
+  articleC.create
+);
+route.patch("/article", articleC.update);


biasanya patch juga ada proses authorization

WikaSilo · 2019-06-24T04:27:54Z

+route.patch("/article", articleC.update);
+route.delete("/article/:id", authorization, articleC.delete);
+
+route.post("/*", (req, res) => {


kenapa ada ini ya?

WikaSilo · 2019-06-24T04:28:56Z

+    let token = jwt.sign(val, process.env.JWT_SECRET);
+    return token;
+  },
+  verify: function(val) {


untuk melakukan proses verify, sebaiknya menggunakan try catch, bukan if else

WikaSilo · 2019-06-24T04:36:52Z

@@ -0,0 +1,54 @@
+const { verify } = require("../helpers/jwt");


tips: nama filenya bisa menggunakan auth

WikaSilo · 2019-06-24T04:37:31Z

+    let token = req.headers.token;
+
+    if (token) {
+      let decode = verify(token);


gunakan try catch untuk memastikan token menggunakan salt yang sama, nanti errornya masalah signature

WikaSilo · 2019-06-24T04:38:12Z

+            req.user = found;
+            next();
+          } else {
+            throw { code: 401, message: `Unauthenticate` };


ini errornya: masalah internal server error

WikaSilo · 2019-06-24T04:39:54Z

+    required: [true, " Email required. "],
+    validate: [
+      {
+        validator: function(value) {


tips: akan lebih rapih jika kamu bungkus dalam helper

WikaSilo · 2019-06-24T04:42:12Z

+  title: String,
+  userId: String,
+  content: String,
+  cretedAt: Date,


tips: sebenarnya ketika membuat schema, kamu bisa menambahkan option timestamps dan dia memiliki createdat dan updatedat

WikaSilo · 2019-06-24T04:42:55Z

+
+let articleSchema = new mongoose.Schema({
+  title: String,
+  userId: String,


bainya kamu menggunakan ref tehadap user yang kamu gunakan

WikaSilo · 2019-06-24T04:47:07Z

+      <section class="hero is-fullheight">
+        <!-- head -->
+        <div class="hero-head">
+          <nav class="navbar">


harusnya bisa dijadikan component

WikaSilo · 2019-06-24T04:47:27Z

+            </div>
+          </div>
+          <!-- end of Article Page -->
+          <!-- GaleryPage -->


bisa dijadikan component

WikaSilo · 2019-06-24T04:47:42Z

+          <!-- end of signIn -->
+        </div>
+        <!-- end of body -->
+        <!-- footer -->


bisa dijadikan component

WikaSilo · 2019-06-24T04:48:03Z

@@ -0,0 +1,340 @@
+<!DOCTYPE html>


masih belum menerapkan Single File Component

WikaSilo · 2019-06-24T04:55:58Z

Jangan push file credential seperti keyfile.json
Penamaan variable sebaiknya jangan articleC, articleR, articleM. Lebih detail saja.
Client belum dijadikan single file component

Yudawardana94 added 9 commits June 19, 2019 11:05

client sementara

2f55373

membuat server bagian user

6dca2b5

progres sejauh ini

0692e5b

re-design client and server side

3f24324

layout tanpa vue

b2f70c1

revisi server Done, modify client progress

b1cc2df

add API DOCUMENTATION

075f0c2

IG Rinda Yuda Wardana

8927f3c

IG Rinda Yuda Wardana

8679966

Yudawardana94 assigned WikaSilo Jun 24, 2019

WikaSilo reviewed Jun 24, 2019

View reviewed changes

Comment thread server/keyfile.json Outdated

@@ -0,0 +1,12 @@

{

Copy link
Copy Markdown

Collaborator

WikaSilo Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jangan push keyfie.json!
dihapus yaa

WikaSilo reviewed Jun 24, 2019

View reviewed changes

Comment thread server/envExample

@@ -0,0 +1,6 @@

PORT=3000

Copy link
Copy Markdown

Collaborator

WikaSilo Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valuenya tidak perlu diisi, kasih kosong saja

WikaSilo reviewed Jun 24, 2019

View reviewed changes

Comment thread client/index.html

@@ -0,0 +1,340 @@

<!DOCTYPE html>

Copy link
Copy Markdown

Collaborator

WikaSilo Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masih belum menerapkan Single File Component

Delete keyfile.json

d35baca

		@@ -0,0 +1,32 @@
		if (!process.env.NODE_ENV \|\| process.env.NODE_ENV === "development") {

		@@ -0,0 +1,13 @@
		const route = require("express").Router();
		const userR = require("../routes/userRoutes");

		@@ -0,0 +1,24 @@
		const route = require("express").Router();
		const articleC = require("../controller/articleController");

		@@ -0,0 +1,54 @@
		const { verify } = require("../helpers/jwt");

Conversation

Yudawardana94 commented Jun 24, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WikaSilo commented Jun 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants