Skip to content

Kharis Khasburrahman#5

Open
khasburrahman wants to merge 54 commits into
eager-fox-2019:masterfrom
khasburrahman:master
Open

Kharis Khasburrahman#5
khasburrahman wants to merge 54 commits into
eager-fox-2019:masterfrom
khasburrahman:master

Conversation

@khasburrahman
Copy link
Copy Markdown

@khasburrahman khasburrahman commented Jun 17, 2019

No description provided.

@khasburrahman
vue directive
e8c0dc3
@khasburrahman
vue
4f19049
@khasburrahman
sidebar toggler in vue
10f4a49
@khasburrahman
add filter article
8e896ce
@khasburrahman
add page detail
934239c
@khasburrahman
add, update, on veu
26c4ade
@khasburrahman
move client to a folder
40d5f21
@khasburrahman
login register
e8738f0
@khasburrahman
delete form html
374157c
@khasburrahman
fix axios config
d8e73f2
@khasburrahman
article
7f5522c
@khasburrahman
move package.json to server
757c30b
@khasburrahman
banyak refactor, kebanyakan changesnya
5587845
@khasburrahman
refactor login and list page
cfe7c2c
@khasburrahman
fix list not appearing in articleList
5ad6103
@khasburrahman
refactor fix update edit article, show detail
f9853b1
@khasburrahman
fix title in form component, fix show new article,
cc908b0
@khasburrahman
add featured image form input in formArticle
4d501bb
@khasburrahman
add gitignore for json key
09f60fd
@khasburrahman
change postArticle to use formData for uplading image
465dcb2
@khasburrahman
implement upload image on google bucket
731be53
@khasburrahman
event emit edit article, and handle edit with image
0793ea5
@khasburrahman
handle change image in article update controller
7ff53e8
@khasburrahman
bind image, add search by title function
2ec1c0f
@khasburrahman
update card style, add delete button
54ddf4d
@khasburrahman
enable and disable some of the sidebar button
3c847af
@khasburrahman
handle url change for form and public page
cc2cee4
@khasburrahman
init route by pathname
bf9f544
@khasburrahman
modify navbar component for use in publicLayout
cffd60a
@khasburrahman
register publicLayout for publicPage
6be0c15
@khasburrahman
create publicLayout
7b47bc9
@khasburrahman
restyle article detail
738a401
@khasburrahman
rebuild css, add new css rule, add buildcss command
80083ca
@khasburrahman
replace the auth middleware, refine list article controller
316df1d
@khasburrahman
fix routing after update / post, fix updating article
c8108f5
@khasburrahman
add _id in pageFormArticle state
a9c2e98
@khasburrahman
change documentation in server
0e5158f
@khasburrahman
add authorization article middleware
0936046
@khasburrahman
add server readme.md to root directory
61fead5
@khasburrahman
implement delete in client
45ed55f
@khasburrahman
Update README.md
248b623 
tambah keterangan alamat deploy
@khasburrahman
add DB_MONGO_PROD_URL when in production
131cf36
@khasburrahman
alter envTemplate
c476a8d
@khasburrahman
Merge branch 'master' of https://github.com/khasburrahman/mini-wp-1
bcf14d6
@khasburrahman
hoc in auth middleware
4e69b47
@khasburrahman
use header when not accessing public page
09a95c4
@khasburrahman
Copy link
Copy Markdown
Author

khasburrahman commented Jun 23, 2019

ini udah diupdate mas @WikaSilo
mau buat pull request baru malah diarahin ke sini.

deploy di: https://kecebadai.khariskhasburrahman.com
ada tampilan blog di root ada buat kelola juga di /admin/ buat pindah pindahnya harus manual di url kaya di wordpress, tapi aplikasinya tetep single page

fitur tambahan: dibuat routing jadi jadian, bisa ngarah ke blog atau halaman untuk admin
udah dicoba buat struktur filenya yang rapi jadi maintainable (?) ntar kasih tau kalo ada yang bisa dibagusin ya mas strukturnya

PORT=3000

DB_USERNAME=mongo
DB_PASSWORD=mongo
DB_HOST=192.168.99.100
DB_PORT=27017
DB_NAME=tamansafarimeisax

SECRET_KEY=bhd87%^*&342ghvE$%E!@RDDSYGUAD

G_BUCKET_NAME=kecebadai.khariskhasburrahman.com
G_BUCKET_KEY_FILE_NAME=./key-gcb.json
GCLOUD_PROJECT=ace-interface-244402

WikaSilo
WikaSilo reviewed Jun 27, 2019
View reviewed changes
Comment thread server/app.js Outdated
* pre route middleware
*/
app.use(cors())
app.use(mongoMiddleware)
Copy link
Copy Markdown
Collaborator

@WikaSilo WikaSilo Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sebaiknya jangan dibuat middleware yaa, karena nanti connectionnya terbuka terus

Copy link
Copy Markdown
Author

@khasburrahman khasburrahman Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siap mas

WikaSilo
WikaSilo reviewed Jun 27, 2019
View reviewed changes
Comment thread server/middlewares/error.middleware.js
@@ -0,0 +1,3 @@
module.exports = (err, req, res, next) => {
res.status(err.code || 500).send(err.msg || err.message)
Copy link
Copy Markdown
Collaborator

@WikaSilo WikaSilo Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

akan lebih baik juga validation error di handle karna bisa jadi lebih dari satu error

WikaSilo
WikaSilo reviewed Jun 27, 2019
View reviewed changes
Comment thread server/controllers/user.controller.js
res.json({_id, email, password})
} catch (err) {
console.log('register error', err)
if (err.code === 11000){
Copy link
Copy Markdown
Collaborator

@WikaSilo WikaSilo Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err.code 11000?

Copy link
Copy Markdown
Author

@khasburrahman khasburrahman Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ini yang duplicate dari index mongo db mas
https://stackoverflow.com/questions/18032879/mongodb-difference-between-error-code-11000-and-11001

@khasburrahman
Copy link
Copy Markdown
Author

khasburrahman commented Jul 3, 2019

Mas wika, yang mongo connection duplicate barusan di push,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WikaSilo WikaSilo WikaSilo left review comments

Assignees

@WikaSilo WikaSilo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khasburrahman @WikaSilo