Merged
Conversation
jhkennedy
reviewed
Mar 28, 2024
Contributor
|
@JessicaS11, do you have time to address @jhkennedy's comments so we can approve and merge your contribution? |
Contributor
Author
|
@chuckwondo Thanks for the ping - it looks like my updates and your message crossed paths. This should be all set. I also just checked against the current |
chuckwondo
approved these changes
May 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #424, I noticed a few of the newer api functions weren't being imported because they hadn't been added to the list in
__init__.py. I update the list and added comments of which modules they're from for clarity. I'm wondering what the incentive for lines 5-17 is (versusfrom .api import *, with the acknowledgement that*isn't best practice - so perhaps there's a better solution) so two manual lists of the functions in .api don't need to be maintained.This work is currently included in #424, but I figured separating it out would be clearer.
📚 Documentation preview 📚: https://earthaccess--461.org.readthedocs.build/en/461/