Adding build platforms #12
Merged
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation on arm64 linux systems support.
Fixes build when compiler refuses to cast 0 int literal to std::string
Add an architecture definition for riscv64. Tests run with 100% passed.
Cmake recently removed support for files using cmake_minimum_required < 3.5. "Compatibility with CMake < 3.5 has been removed from CMake."
Bugfix for cmake version
Add support for Linux arm64 build
Add support for Linux riscv64 build
Fix URI::ToFilename return value for error handling case
Switch to tag 1.0.0 of URIParser
Updating URI Parser dependency
irieger
reviewed
Jan 27, 2026
irieger
left a comment
irieger
left a comment
There was a problem hiding this comment.
Just saw this one point here where I'm not sure if it is of any relevance, but it breaks with the surrounding blocks where the MXF_OS_UNIX is defined.
Co-authored-by: Ingmar Rieger <git@irieger.net>
emcodem
approved these changes
Jan 28, 2026
Collaborator
emcodem
left a comment
emcodem
left a comment
There was a problem hiding this comment.
URIParser got more strict, we might need to deal with it later.
The rest seems straight forward to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining multiple pull requests for adding build platforms and fixing build issues due to Cmake updates and modern compilers.