Skip to content

Fix Java Language tests#21

Open
echebbi wants to merge 2 commits into
masterfrom
fix-java-language-tests
Open

Fix Java Language tests#21
echebbi wants to merge 2 commits into
masterfrom
fix-java-language-tests

Conversation

@echebbi
Copy link
Copy Markdown
Owner

@echebbi echebbi commented Dec 27, 2018

As a remember the issue was that when testing dynamic loading of Java Runners runtime errors was occuring randomly.

In the end the issue was that the Eclipse project was not properly imported. Updating ImportableProject class solved the issue.

@echebbi echebbi added the a: bug fix 🎁 Fixes a bug label Dec 27, 2018
@echebbi echebbi self-assigned this Dec 27, 2018
As a remember the issue was that when testing dynamic loading
of Java Runners runtime errors was occuring randomly.

In the end the issue was that the Eclipse project was not properly
imported. Updating ImportableProject class solved the issue.
@echebbi echebbi force-pushed the fix-java-language-tests branch from ce5aff5 to af85d0e Compare December 27, 2018 22:39
@echebbi
Copy link
Copy Markdown
Owner Author

echebbi commented Dec 27, 2018

Tests pass successfully in my local system but fail in Travis CI. It seems that Travis launches the runtime Eclipse IDE in read-only mode and prevent the import of the new project.

Because of this issue the branch cannot be merged right now, so I'll wait until the problem is fixed.

@echebbi echebbi force-pushed the fix-java-language-tests branch from d1a3cd2 to 293c85f Compare January 2, 2019 16:28
@echebbi
Copy link
Copy Markdown
Owner Author

echebbi commented Jan 2, 2019

After further investigation it seems that the issue is caused by the JDT. Indeed, on some computers JavaRuntime.computeDefaultRuntimeClassPath(javaProject) (called in JavaLanguage.getClassLoader) returns absolute classpaths whereas on others it returns relative classpaths.

The code expects absolute classpath and then fails when they are relative. I did not manage to find what causes this difference yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: bug fix 🎁 Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant