Should explicitly report the fatal settings error#2089
Merged
snjeza merged 1 commit intoeclipse-jdtls:masterfrom May 28, 2022
Merged
Should explicitly report the fatal settings error#2089snjeza merged 1 commit intoeclipse-jdtls:masterfrom
snjeza merged 1 commit intoeclipse-jdtls:masterfrom
Conversation
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
This was referenced May 13, 2022
snjeza
changed the title
snjeza
changed the title
rgrunber
approved these changes
May 26, 2022
Contributor
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Looks fine to me. Logging and continuing seems like the right thing to do.
testforstephen
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#2429
Requires redhat-developer/vscode-java#2451
Test vsix: https://github.com/snjeza/vscode-test/raw/master/java-1.6.1.vsix
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com