[hono] Add support for JDBC device registry#164
Conversation
lhotari
force-pushed
the
lh-hono-device-registry-jdbc
branch
2 times, most recently
from
3577b3a to
821f985
Compare
lhotari
force-pushed
the
lh-hono-device-registry-jdbc
branch
2 times, most recently
from
c47c934 to
ba67aa6
Compare
ctron
left a comment
ctron
left a comment
There was a problem hiding this comment.
Looks good to me. But I will leave it for others to comment as well.
|
Looks good to me. With this PR, we can use this chart to deploy the JDBC device registry and connect to an already existing JDBC database. In order to provide an out of the box experience, I think its good to have an option to install a JDBC database instance on the fly. And the JDBC registry can connect to it as we do in the MongoDB device registry. I remember that in some meeting we talked about using a H2 database instance for that. Also it can be done as a separate PR. |
lhotari
force-pushed
the
lh-hono-device-registry-jdbc
branch
from
ecaef9e to
2fd9e33
Compare
| username: | ||
| # The password to use for authenticating to the database | ||
| password: | ||
|
|
There was a problem hiding this comment.
it would be nice to have default configuration for using an in memory H2 DB so that you can simply start the registry and use it, without the need to set a lot of configuration properties ...
There was a problem hiding this comment.
point taken, however setting up h2 using a persistent file would require quite some changes to the helm chart. Would in-memory h2 be ok?
There was a problem hiding this comment.
sure, we can still evolve from there ...
There was a problem hiding this comment.
I am not sure I get the issue with persistence. That would be one pvc and a volume mapping in case of h2. Could be a simple feature flag to enable that.
|
@lhotari Can you rebase and resolve the conflict? |
lhotari
force-pushed
the
lh-hono-device-registry-jdbc
branch
from
2fd9e33 to
550ae06
Compare
@calohmn yes, that's done now. |
|
hi @lhotari we have released Hono 1.5.0 today and it would be cool if we could add your changes now to the Helm chart. Would you mind rebasing your PR and bumping the chart version? |
Fixes eclipse-packages#163 Signed-off-by: Lari Hotari <lari@hotari.net>
lhotari
force-pushed
the
lh-hono-device-registry-jdbc
branch
from
550ae06 to
85d4287
Compare
@sophokles73 I have rebased my PR and bumped the chart version to 1.4.17 . Is that correct? |
|
@lhotari thanks for contributing 👍 |
5 participants
Motivation
Add support for using JDBC based device & tenant registry in the Hono Helm chart.
JDBC based device registries will be part of the upcoming Hono 1.5.0 release.
Fixes #163
Dependencies
mvn clean install -Pbuild-docker-image,metrics-prometheus && ./push_hono_images.sh 1.5.0-SNAPSHOT mycustomcr.azurecr.io