Skip to content

Fixing left over fd on child processes#289

Merged
NicolasFussberger merged 7 commits into
eclipse-score:mainfrom
etas-contrib:fix-leaked-fd
Jul 13, 2026
Merged

Fixing left over fd on child processes#289
NicolasFussberger merged 7 commits into
eclipse-score:mainfrom
etas-contrib:fix-leaked-fd

Conversation

@MaciejKaszynski

Copy link
Copy Markdown
Contributor

Found that a child process might inherit a file descriptor, the file is deleted but still not good to have it.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: ada3523a-6c04-4dc5-96e1-1874957d8fb2
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 10 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (92 packages loaded, 17 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2767 targets configured)

Analyzing: target //:license-check (156 packages loaded, 5498 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10275 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (169 packages loaded, 10409 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.380s, Critical Path: 2.38s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread tests/integration/process_fd_leak/get_fds.hpp Outdated
Comment thread tests/integration/process_fd_leak/control_client.cpp

@SimonKozik SimonKozik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SimonKozik SimonKozik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit looks OK

Comment thread score/launch_manager/src/daemon/src/main.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/main.cpp Outdated
Comment thread tests/integration/process_fd_leak/process_fd_leak.py Outdated
Comment thread score/launch_manager/src/daemon/src/main.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/main.cpp Outdated
@NicolasFussberger

Copy link
Copy Markdown
Contributor

Looks like some of the tests are failing in the pipeline https://github.com/eclipse-score/lifecycle/actions/runs/29103108047/job/86396720862?pr=289

@NicolasFussberger NicolasFussberger merged commit 33df5f8 into eclipse-score:main Jul 13, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants