Register assertion handler to print failure details to stderr#299
Open
shegazyy wants to merge 2 commits into
Open
Register assertion handler to print failure details to stderr#299shegazyy wants to merge 2 commits into
shegazyy wants to merge 2 commits into
Conversation
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
Author
|
Hey @danth 🙏 ready for review whenever you have a moment! |
|
The created documentation from the pull request is available at: docu-html |
danth
suggested changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
When an assertion fails inside bazel test, the punctuation gets split onto separate lines:
[2026-07-09 09:38:49.947] [INFO] [launch_manager] Assertion failed:
[2026-07-09 09:38:49.947] [INFO] [launch_manager] osal_result != OsalReturnType::kSuccess
[2026-07-09 09:38:49.947] [INFO] [launch_manager] Location:
[2026-07-09 09:38:49.947] [INFO] [launch_manager] score/launch_manager/src/daemon/src/process_group_manager/details/process_group_manager.cpp
[2026-07-09 09:38:49.947] [INFO] [launch_manager] :
[2026-07-09 09:38:49.947] [INFO] [launch_manager] 166
[2026-07-09 09:38:49.947] [INFO] [launch_manager] (
[2026-07-09 09:38:49.947] [INFO] [launch_manager] bool score::lcm::internal::ProcessGroupManager::initializeControlClientHandler()
[2026-07-09 09:38:49.947] [INFO] [launch_manager] )
[2026-07-09 09:38:49.948] [INFO] [launch_manager] Message:
[2026-07-09 09:38:49.948] [INFO] [launch_manager] ControlClientChannel semaphore init failed
Maybe we should build the string and write it to cerr in one go (or at most once per line) to avoid this.
Without a registered handler, SCORE_LANGUAGE_FUTURECPP_ASSERT failures call std::abort silently, giving no indication of what failed or where. Register a handler at daemon startup that writes the failed condition, optional message, file, line, and function to stderr before abort. Closes: eclipse-score#296
shegazyy
force-pushed
the
fix/make-assertion-messages-visible
branch
from
e7fb36e to
5cbbe7c
Compare
shegazyy
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
shegazyy
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
danth
approved these changes
Jul 13, 2026
NicolasFussberger
approved these changes
Jul 13, 2026
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Contributor
Author
|
@NicolasFussberger @danth branch is updated with the latest main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a registered handler, SCORE_LANGUAGE_FUTURECPP_ASSERT failures call std::abort silently, giving no indication of what failed or where.
Register a handler at daemon startup that writes the failed condition, optional message, file, line, and function to stderr before abort.
Closes: #296