Skip to content

Conversation

@NEOatNHNG
Copy link
Contributor

@NEOatNHNG NEOatNHNG commented Jan 9, 2026

Don't fetch starpls via bazel and use the one installed on the system or devcontainer instead.

Also clean up and fix some other vscode settings.

Related ticket

Addresses eclipse-score/tooling#79 (bugfix ticket)

Also cleaned up vscode configuration.
It is already present in the devcontainer.

Addresses eclipse-score/tooling#79
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: acb26083-19b8-4997-91f5-265feb0b67d8
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (68 packages loaded, 9 targets configured)

Analyzing: target //:license-check (94 packages loaded, 44 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2403 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2716 targets configured)

Analyzing: target //:license-check (148 packages loaded, 4723 targets configured)

Analyzing: target //:license-check (148 packages loaded, 4723 targets configured)

Analyzing: target //:license-check (148 packages loaded, 4723 targets configured)

INFO: Analyzed target //:license-check (149 packages loaded, 6658 targets configured).
[8 / 13] checking cached actions
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[12 / 13] checking cached actions
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 190.753s, Critical Path: 0.38s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

The created documentation from the pull request is available at: docu-html

@NEOatNHNG NEOatNHNG marked this pull request as ready for review January 9, 2026 16:31
@NEOatNHNG NEOatNHNG requested review from Aymen-Soussi-01 and nicu1989 and removed request for nicu1989 January 12, 2026 09:20
// BasedPyright for python various type checking improvements and pylance features
"detachhead.basedpyright",
// Bazel BUILD integration
"bazelbuild.vscode-bazel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incompatible with docs-as-code preview, that's why we did not include it. No idea if people use that preview feature or not.

99
],

// Exclude build, temp and cache folders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like this file (actually both) will be much harder to read without the newlines

Comment on lines +57 to +59
"files.insertFinalNewline": false,
"files.trimFinalNewlines": false,
"files.trimTrailingWhitespace": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Draft

Development

Successfully merging this pull request may close these issues.

2 participants