-
Notifications
You must be signed in to change notification settings - Fork 273
Add support for GfM alerts #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
please sign the eca, more details can be found here: https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1535 |
|
Maybe I'm simply impatient. I signed the ECA, got a success message and was redirected here. The status of the ECA workflow is unchanged. When I click your link above, it appears that it's not signed (I've tried several times since, again, maybe I should be more patient?) |
|
revalidation is usually a manual process, in the details view there is a |
|
the version of However, after further analysis, this CVE is probably not valid, and we should not be affected at at all we do not use the highlight fuctionality. |
|
May I ask you to also look into this PR #1399 to change from webpack to vite for improved developer experience to gather feedback if this would be a useful change? |
IMHO, there's a massive benefit in switching to Vite, the API is much simpler and all the tooling is much faster. I also love the integration with testing tools such as Vitests. I left some comments in the PR, but nothing major. |
|
if you are fine with my changes I can go ahead and merge the PR. Thanks a lot anyways for this contribution. |
|
Love the icons. PR LGTM. |


This PR adds support for GfM alerts, closing #1509. The styling is subjective, of course, but I tried to make it align with the current design as much as possible.