Skip to content

Conversation

@idleberg
Copy link
Contributor

This PR adds support for GfM alerts, closing #1509. The styling is subjective, of course, but I tried to make it align with the current design as much as possible.

@idleberg idleberg changed the title Feature/gfm alerts Add support for GfM alerts Jan 11, 2026
@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

please sign the eca, more details can be found here: https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1535

@idleberg
Copy link
Contributor Author

Maybe I'm simply impatient. I signed the ECA, got a success message and was redirected here. The status of the ECA workflow is unchanged. When I click your link above, it appears that it's not signed (I've tried several times since, again, maybe I should be more patient?)

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

revalidation is usually a manual process, in the details view there is a Revalidate button. After you have signed the ECA the validation shall succeed, which did in your case.

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

tested the PR, looks good:

image

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

the version of markdown-it that you bumped to has received a CVE: markdown-it/markdown-it#1122

However, after further analysis, this CVE is probably not valid, and we should not be affected at at all we do not use the highlight fuctionality.

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

I have amended the PR with a changelog entry (which we do now explicitly for the webui components as they are also released to npm and we would like to know what changes went into the package) and added the icons as well to the alert box to make it a bit nicer:

image

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

May I ask you to also look into this PR #1399 to change from webpack to vite for improved developer experience to gather feedback if this would be a useful change?

@idleberg
Copy link
Contributor Author

May I ask you to also look into this PR #1399 to change from webpack to vite for improved developer experience to gather feedback if this would be a useful change?

IMHO, there's a massive benefit in switching to Vite, the API is much simpler and all the tooling is much faster. I also love the integration with testing tools such as Vitests.

I left some comments in the PR, but nothing major.

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

if you are fine with my changes I can go ahead and merge the PR. Thanks a lot anyways for this contribution.

@netomi netomi added webui (Component: webui) Front-end user interface for open-vsx.org javascript Pull requests that update JavaScript code labels Jan 12, 2026
@idleberg
Copy link
Contributor Author

Love the icons. PR LGTM.

@netomi netomi merged commit df0e2b7 into eclipse:master Jan 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update JavaScript code webui (Component: webui) Front-end user interface for open-vsx.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants