fix: repair PortfolioPage test mocks and add missing jsdom polyfills#2
Open
team2human wants to merge 2 commits intoed-donner:mainfrom
Open
fix: repair PortfolioPage test mocks and add missing jsdom polyfills#2team2human wants to merge 2 commits intoed-donner:mainfrom
team2human wants to merge 2 commits intoed-donner:mainfrom
Conversation
added 2 commits
April 14, 2026 16:44
…rce, ResizeObserver (fin-31f6)
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lightweight-chartsmock to useaddSeries+LineSeriesexport (matching actual v5 API used inMainChart.tsx)addEventListener/removeEventListenertoMockEventSource(required byuseMarketDatahook)ResizeObserverpolyfill to test setup (jsdom doesn't implement it, needed byMainChart)Test plan
npm test— all 37 tests pass (was 4 failures before fix)npm run build— static export succeedsnpm run lint— cleanCloses fin-31f6
🤖 Generated with Claude Code