Fix/market data review#35
Open
stevehome wants to merge 9 commits intoed-donner:mainfrom
Open
Conversation
- Add project README.md with setup, architecture, and dev instructions - Update PLAN.md: switch LLM integration from OpenRouter to direct Cerebras API, add review notes and open questions section, clarify SSE/portfolio/chat details - Update cerebras SKILL.md to reflect direct Cerebras API via LiteLLM Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…7066532 1Add Claude Code GitHub Workflow
…ommands - Increment _version in PriceCache.remove() so SSE clients detect ticker removals - Add planning review and API docs - Add Claude commands and plugin config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comprehensive review of backend/app/market/ covering test results (73/73 passing), coverage analysis (91% overall), and identified issues with recommendations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add market data code review
…fety and design issues - PriceCache.version: acquire lock (free-threaded Python safety, 4.2) - GBMSimulator._add_ticker_internal: remove dead guard, add caller contract note (4.1) - SimulatorDataSource add/remove_ticker: document start() pre-condition (4.5) - stream.py: move APIRouter creation inside create_stream_router() to prevent double-registration (4.4) - Add test_stream.py: 7 new tests covering _generate_events, router factory, and handler response (4.3) - Add test for all 10 default tickers Cholesky decomposition (4.6) - Add httpx to dev dependencies for async test client Coverage: 91% → 98%. All 81 tests pass, lint clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
extra tests and fixes |
Code reviewFound 2 issues:
Lines 42 to 46 in 639ee2e
finally/planning/MARKET_API.md Lines 184 to 188 in 639ee2e 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.