Fix spaces-in-path (%20) bug and add missing tsx dependency#22
Open
tomiin wants to merge 1 commit into
Open
Conversation
|
@tomiin is attempting to deploy a commit to the erickrs2's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Friendly follow-up on this one. Both fixes are small but they block a fresh clone from running: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs prevent the template from running out of the box on a fresh clone. This PR fixes both.
1.
%20spaces-in-path bug (breakssetup-standaloneand the contract build on any path containing a space)counter-cli/src/config.tsandcounter-contract/src/config.tsbuildcurrentDirwith:new URL(import.meta.url).pathnameleaves spaces URL-encoded as%20. On any project path with a space (e.g. the default macOS~/Documents/...), the resolved path becomes a literal…Midnight%20code…, so file lookups fail.pnpm setup-standalonedies with:Fix: use
fileURLToPath(import.meta.url), which decodes the path correctly and works whether or not the path contains spaces.2. Missing
tsxdependency incounter-clicounter-cli's scripts (setup-undeployed,tui-undeployed/preview/preprod) invoketsx, buttsxisn't declared anywhere in the package. With pnpm's strictnode_modules,tsxisn't onPATH, so a freshpnpm install+pnpm setup-standalonefails with:Fix: add
tsxtocounter-cli'sdevDependencies.Testing
After both fixes,
pnpm install && pnpm build && pnpm setup-standaloneruns cleanly from a path that contains spaces.Built on / for Midnight. 🌙