Updated XRControllerInputRemapper. The changes made to XRControllerIn…

[thefirstfloor]

It seems that unity updated some things in their input system.
Some changes were needed in the remapper script, also some validations are added to avoid exceptions and leftovers.

A.i claims:
…putRemapperNew.cs are fully compatible with versions of the Unity Input System package prior to 1.19.0 (including versions as old as 1.0.0).

[thefirstfloor]

@eioe

[Copilot]

Pull request overview

This PR updates the XR controller input remapping MonoBehaviour to align with newer Unity Input System behavior by moving subscription management into the component lifecycle and adding guards to avoid null/index exceptions.

Changes:

• Renamed the remapper MonoBehaviour type and adjusted component lifecycle methods to subscribe/unsubscribe in OnEnable/OnDisable.
• Added validation to avoid FindIndex/null-reference exceptions when enabling/disabling remaps.
• Introduced a runtime isSubscribed flag to prevent duplicate event subscriptions.

Comments suppressed due to low confidence (1)

Assets/com.edia.core/Runtime/Base/Scripts/XR/XRControllerInputRemapper.cs:69

• Subscribe/Unsubscribe assumes methodToCall is non-null (r.methodToCall.Invoke). If ControllerInputRemap entries are ever created programmatically (not via Unity serialization), methodToCall will be null and this will throw at subscription time. Consider initializing methodToCall (e.g., to a new UnityEvent) and/or adding a null check before subscribing/unsubscribing.

		private void Subscribe(ControllerInputRemap r) {
			if (r.isSubscribed || r.inputActionSubmit == null || r.inputActionSubmit.action == null) return;
			
			r.inputActionSubmit.action.Enable();
			r.inputActionSubmit.action.performed += r.methodToCall.Invoke;
			r.isSubscribed = true;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.