fix: Added RequestException class to fix unhandled exception#116
Merged
shafqatfarhan merged 1 commit intomainfrom Aug 18, 2025
Merged
fix: Added RequestException class to fix unhandled exception#116shafqatfarhan merged 1 commit intomainfrom
shafqatfarhan merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an unhandled exception by adding urllib3's HTTPError class to the exception handling in the SDN check functionality. The change ensures that both requests and urllib3 HTTP errors are properly caught and handled by the fallback mechanism.
- Added urllib3.exceptions.HTTPError import and exception handling
- Updated test coverage to verify both urllib3 and requests HTTPError exceptions are handled
- Renamed existing test method to clarify it specifically tests requests HTTPError
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sanctions/apps/api/v1/views.py | Added urllib3.exceptions.HTTPError to exception handling in SDN check |
| sanctions/apps/api/v1/tests/test_views.py | Added test for urllib3 HTTPError and renamed existing test for clarity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
syedsajjadkazmii
approved these changes
Aug 18, 2025
431dff2 to
5e995f3
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
5e995f3 to
e7a56bb
Compare
syedsajjadkazmii
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge checklist:
Check off if complete or not applicable:
Post-merge: