Ad-hoc Event Tracking#649
Open
Jumana-K wants to merge 5 commits into
Open
Conversation
Member
|
@Jumana-K Add output screenshots/recording |
SherinKR
requested changes
Jun 8, 2026
SherinKR
left a comment
SherinKR
left a comment
Member
There was a problem hiding this comment.
Can we use is_event flag for identifying event tasks?
SherinKR
requested changes
Jun 10, 2026
| """ | ||
| user = frappe.session.user | ||
| settings = frappe.db.get_value("Projects Settings", "Projects Settings", ["ignore_employee_time_overlap", "ignore_user_time_overlap"], as_dict=True) or {} | ||
| ignore_overlap = (int(settings.get("ignore_employee_time_overlap") or 0) == 1) or (int(settings.get("ignore_user_time_overlap") or 0) == 1) |
| val2 = frappe.db.get_value("Projects Settings", "Projects Settings", "ignore_user_time_overlap") | ||
| ignore_overlap = (int(val1 or 0) == 1) or (int(val2 or 0) == 1) | ||
| settings = frappe.db.get_value("Projects Settings", "Projects Settings", ["ignore_employee_time_overlap", "ignore_user_time_overlap"], as_dict=True) or {} | ||
| ignore_overlap = (int(settings.get("ignore_employee_time_overlap") or 0) == 1) or (int(settings.get("ignore_user_time_overlap") or 0) == 1) |
SherinKR
requested changes
Jun 10, 2026
Comment on lines
+411
to
+412
| return (int(settings.get("ignore_employee_time_overlap") or 0) == 1) or \ | ||
| (int(settings.get("ignore_user_time_overlap") or 0) == 1) |
Member
There was a problem hiding this comment.
As it's the custom doctype, the fields should exists there, So it can be refactored to return bool(settings.ignore_employee_time_overlap or settings.ignore_user_time_overlap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
Task:TASK-2026-00549
Ad-hoc Event Logging feature with timer support, Event creation and Timesheet integration across Task and Project Management Tools.
Output screenshots (optional)
Screen Recording 2026-06-09 at 11.04.40 AM.zip
Was this feature tested on these browsers?