Skip to content

Fix download_eggnog_data.py database URL#574

Open
AggressiveHayBale wants to merge 1 commit intoeggnogdb:masterfrom
AggressiveHayBale:master
Open

Fix download_eggnog_data.py database URL#574
AggressiveHayBale wants to merge 1 commit intoeggnogdb:masterfrom
AggressiveHayBale:master

Conversation

@AggressiveHayBale
Copy link
Copy Markdown

Per issue #571 and @jelmerp suggestion the BASE_URL and NOVEL_FAMS_BASE_URL URL's 404 error making impossible to download database.

The small fix changes base url from eggnogdb.embl.de to eggnog5.embl.de

It is tested and it is working

@AggressiveHayBale
Copy link
Copy Markdown
Author

I don't want to be annoying but could you look at that @Cantalapiedra ? It is a simple solution but at the moment people can't use the tool that easily.

@theSamurai1997
Copy link
Copy Markdown

@AggressiveHayBale Thank you for your comment. It helped to resolve the issue.

@AggressiveHayBale
Copy link
Copy Markdown
Author

@AggressiveHayBale Thank you for your comment. It helped to resolve the issue.

Happy to help!

@Rhylan2333
Copy link
Copy Markdown

True! Change "eggnogdb.embl.de" in download_eggnog_data.py to "eggnog5.embl.de".

# BASE_URL = f'http://eggnogdb.embl.de/download/emapperdb-{__DB_VERSION__}'
BASE_URL = f'http://eggnog5.embl.de/download/emapperdb-{__DB_VERSION__}'
EGGNOG_URL = f'http://eggnog5.embl.de/download/eggnog_5.0/per_tax_level'
EGGNOG_DOWNLOADS_URL = 'http://eggnog5.embl.de/#/app/downloads'
# NOVEL_FAMS_BASE_URL = f'http://eggnogdb.embl.de/download/novel_fams-{__NOVEL_FAMS_DB_VERSION__}'
NOVEL_FAMS_BASE_URL = f'http://eggnog5.embl.de/download/novel_fams-{__NOVEL_FAMS_DB_VERSION__}'

@anthony-aylward
Copy link
Copy Markdown

For anyone waiting for this to be implemented, for my own convenience I've written a Python package to make the fix in a simple way. See it on PyPI, in case you find it useful:

https://pypi.org/project/eggnog-mapper-fixurl/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants