Fix download_eggnog_data.py database URL#574
Open
AggressiveHayBale wants to merge 1 commit intoeggnogdb:masterfrom
Open
Fix download_eggnog_data.py database URL#574AggressiveHayBale wants to merge 1 commit intoeggnogdb:masterfrom
AggressiveHayBale wants to merge 1 commit intoeggnogdb:masterfrom
Conversation
RoshTzsche
approved these changes
Oct 12, 2025
Author
|
I don't want to be annoying but could you look at that @Cantalapiedra ? It is a simple solution but at the moment people can't use the tool that easily. |
|
@AggressiveHayBale Thank you for your comment. It helped to resolve the issue. |
Author
Happy to help! |
|
True! Change "eggnogdb.embl.de" in # BASE_URL = f'http://eggnogdb.embl.de/download/emapperdb-{__DB_VERSION__}'
BASE_URL = f'http://eggnog5.embl.de/download/emapperdb-{__DB_VERSION__}'
EGGNOG_URL = f'http://eggnog5.embl.de/download/eggnog_5.0/per_tax_level'
EGGNOG_DOWNLOADS_URL = 'http://eggnog5.embl.de/#/app/downloads'
# NOVEL_FAMS_BASE_URL = f'http://eggnogdb.embl.de/download/novel_fams-{__NOVEL_FAMS_DB_VERSION__}'
NOVEL_FAMS_BASE_URL = f'http://eggnog5.embl.de/download/novel_fams-{__NOVEL_FAMS_DB_VERSION__}' |
|
For anyone waiting for this to be implemented, for my own convenience I've written a Python package to make the fix in a simple way. See it on PyPI, in case you find it useful: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per issue #571 and @jelmerp suggestion the BASE_URL and NOVEL_FAMS_BASE_URL URL's 404 error making impossible to download database.
The small fix changes base url from eggnogdb.embl.de to eggnog5.embl.de
It is tested and it is working